Bug 56438 - Make Structure creation require a JSGlobalData
Summary: Make Structure creation require a JSGlobalData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 18:21 PDT by Oliver Hunt
Modified: 2011-03-16 14:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (121.49 KB, patch)
2011-03-15 18:26 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (123.00 KB, patch)
2011-03-16 10:05 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (123.99 KB, patch)
2011-03-16 10:27 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (127.29 KB, patch)
2011-03-16 11:00 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (127.99 KB, patch)
2011-03-16 11:27 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (128.12 KB, patch)
2011-03-16 11:41 PDT, Oliver Hunt 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-03-15 18:21:57 PDT 
Make Structure creation require a JSGlobalData
Comment 1 Oliver Hunt 2011-03-15 18:26:06 PDT 
Created attachment 85892 [details]
Patch
Comment 2 Early Warning System Bot 2011-03-15 18:44:00 PDT 
Attachment 85892 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8177787
Comment 3 Build Bot 2011-03-15 21:52:45 PDT 
Attachment 85892 [details] did not build on win:
Build output: http://queues.webkit.org/results/8177848
Comment 4 WebKit Review Bot 2011-03-16 01:55:47 PDT 
Attachment 85892 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8187066
Comment 5 Oliver Hunt 2011-03-16 10:05:45 PDT 
Created attachment 85937 [details]
Patch

Include missing change that broke qt,mac,etc and remove exports from windows
Comment 6 Early Warning System Bot 2011-03-16 10:19:56 PDT 
Attachment 85937 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8187233
Comment 7 Oliver Hunt 2011-03-16 10:27:37 PDT 
Created attachment 85939 [details]
Patch

Include change properly this time
Comment 8 Build Bot 2011-03-16 10:35:17 PDT 
Attachment 85937 [details] did not build on win:
Build output: http://queues.webkit.org/results/8193079
Comment 9 Early Warning System Bot 2011-03-16 10:43:47 PDT 
Attachment 85939 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8193082
Comment 10 Oliver Hunt 2011-03-16 11:00:58 PDT 
Created attachment 85942 [details]
Patch

Fix QT
Comment 11 Early Warning System Bot 2011-03-16 11:25:28 PDT 
Attachment 85942 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8191143
Comment 12 Oliver Hunt 2011-03-16 11:27:41 PDT 
Created attachment 85945 [details]
Patch

Fix QT again
Comment 13 Build Bot 2011-03-16 11:36:47 PDT 
Attachment 85942 [details] did not build on win:
Build output: http://queues.webkit.org/results/8188278
Comment 14 Oliver Hunt 2011-03-16 11:41:32 PDT 
Created attachment 85950 [details]
Patch

Fix windows build
Comment 15 Build Bot 2011-03-16 12:04:41 PDT 
Attachment 85939 [details] did not build on win:
Build output: http://queues.webkit.org/results/8189194
Comment 16 Geoffrey Garen 2011-03-16 12:13:17 PDT 
Comment on attachment 85950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85950&action=review

r=me if this builds and you make the change below.

> Source/JavaScriptCore/runtime/JSGlobalData.cpp:144
> +    , dummyMarkableCellStructure(JSCell::createDummyStructure(*this))

Please ensure these are initialized after heap. You need to verify that moving the heap data member is not a performance regression. Previously, SunSpider has shown itself to be sensitive to the location of some of those data members.
Comment 17 Oliver Hunt 2011-03-16 13:14:27 PDT 
Committed r81272: <http://trac.webkit.org/changeset/81272>
Comment 18 WebKit Review Bot 2011-03-16 14:19:52 PDT 
http://trac.webkit.org/changeset/81272 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
java/lc3/JSObject/ToObject-001.html