Bug 56422 - Removed a few more deprecatedAppends, and removed HeapRoot<T>
Summary: Removed a few more deprecatedAppends, and removed HeapRoot<T>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 15:52 PDT by Geoffrey Garen
Modified: 2011-03-15 23:56 PDT (History)
3 users (show)

See Also:


Attachments
Patch (18.24 KB, patch)
2011-03-15 15:56 PDT, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-03-15 15:52:41 PDT
Removed a few more deprecatedAppends, and removed HeapRoot<T>
Comment 1 Geoffrey Garen 2011-03-15 15:56:44 PDT
Created attachment 85867 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-15 15:58:25 PDT
Attachment 85867 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/SmallStrings.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2011-03-15 16:14:57 PDT
Comment on attachment 85867 [details]
Patch

A nice follow up would be a list append to HeapRootMarker that could then be used by HandleStack
Comment 4 Geoffrey Garen 2011-03-15 16:30:01 PDT
Committed r81191: <http://trac.webkit.org/changeset/81191>
Comment 5 WebKit Review Bot 2011-03-15 23:56:55 PDT
http://trac.webkit.org/changeset/81191 might have broken WinCE Release (Build)