Bug 56417 - [Qt][Symbian][WK2] Fix exporting and importing WebProcessMainQt
Summary: [Qt][Symbian][WK2] Fix exporting and importing WebProcessMainQt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 50251
  Show dependency tree / graph
 
Reported: 2011-03-15 14:48 PDT by Laszlo Gombos
Modified: 2011-03-15 23:56 PDT (History)
6 users (show)

See Also:

Attachments
fix to land for cq+ (2.11 KB, patch)
2011-03-15 15:00 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-03-15 14:48:51 PDT 
Both in WebKit2/qt/MainQt.cpp and in WebKit2/WebProcess/qt/WebProcessMainQt.cpp QWEBKIT_EXPORT is defined to an empty string; so the WebProcessMainQt symbol does not get properly exported/imported. This is likely not only a problem on Symbian/RVCT but on Windows/MSVC as well.
Comment 1 Laszlo Gombos 2011-03-15 15:00:17 PDT 
Created attachment 85861 [details]
fix to land for cq+

Fix looks good to me, r+.
Comment 2 WebKit Commit Bot 2011-03-15 15:55:24 PDT 
Comment on attachment 85861 [details]
fix to land for cq+

Clearing flags on attachment: 85861

Committed r81186: <http://trac.webkit.org/changeset/81186>
Comment 3 WebKit Commit Bot 2011-03-15 15:55:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2011-03-15 23:56:44 PDT 
http://trac.webkit.org/changeset/81186 might have broken WinCE Release (Build)