Bug 56416 - Add script to convert a patch to a prettypatch and show in the default browser
Summary: Add script to convert a patch to a prettypatch and show in the default browser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 14:34 PDT by Sam Weinig
Modified: 2011-03-16 00:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.86 KB, patch)
2011-03-15 14:35 PDT, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-03-15 14:34:07 PDT 
Add script to convert a patch to a prettypatch and show in the default browser
Comment 1 Sam Weinig 2011-03-15 14:35:22 PDT 
Created attachment 85860 [details]
Patch
Comment 2 Darin Adler 2011-03-15 15:56:43 PDT 
Comment on attachment 85860 [details]
Patch

Calling it pretty-diff makes it sound like a diff tool. Maybe you could name it some way that makes it clear that its input is a “patch” or “diff” rather than making it seem like the tool is a “diff” tool.
Comment 3 Sam Weinig 2011-03-15 18:20:06 PDT 
Landed as show-pretty-diff in r81206.
Comment 4 WebKit Review Bot 2011-03-15 23:57:53 PDT 
http://trac.webkit.org/changeset/81206 might have broken WinCE Release (Build)
Comment 5 Eric Seidel (no email) 2011-03-16 00:04:19 PDT 
webkit-patch pretty-diff already knows how to show the current diff as a pretty diff.  But it's always good to have more tools. :)