Bug 56403 - [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
Summary: [GStreamer] There is no need to set the state of the pipeline to playing, HTM...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Alexis Menard (darktears)
Depends on:
Reported: 2011-03-15 13:02 PDT by Alexis Menard (darktears)
Modified: 2011-03-16 03:44 PDT (History)
4 users (show)

See Also:

Proposed patch. (2.00 KB, patch)
2011-03-15 13:07 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-03-15 13:02:17 PDT
In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING); As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched i.e the pause() made when beginScrubbing is done is just internal.
Comment 1 Alexis Menard (darktears) 2011-03-15 13:07:30 PDT
Created attachment 85845 [details]
Proposed patch.
Comment 2 Martin Robinson 2011-03-15 15:52:34 PDT
Comment on attachment 85845 [details]
Proposed patch.

Looks good to me, but I'd like Philippe to take a look at this as well before you land it.
Comment 3 Philippe Normand 2011-03-16 01:49:08 PDT
Comment on attachment 85845 [details]
Proposed patch.

Yep I discussed about this patch with Alexis, I tested it on GTK, no regression spotted!
Comment 4 WebKit Commit Bot 2011-03-16 03:37:08 PDT
The commit-queue encountered the following flaky tests while processing attachment 85845 [details]:

transitions/interrupted-accelerated-transition.html bug 56242 (authors: simon.fraser@apple.com and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-03-16 03:44:39 PDT
Comment on attachment 85845 [details]
Proposed patch.

Clearing flags on attachment: 85845

Committed r81234: <http://trac.webkit.org/changeset/81234>
Comment 6 WebKit Commit Bot 2011-03-16 03:44:43 PDT
All reviewed patches have been landed.  Closing bug.