RESOLVED FIXED 56394
Introduce Local<T> to allow us to start moving to precise marking of locals 
https://bugs.webkit.org/show_bug.cgi?id=56394
Summary Introduce Local<T> to allow us to start moving to precise marking of locals
Oliver Hunt
Reported 2011-03-15 11:42:50 PDT
Introduce Local<T> to allow us to start moving to precise marking of locals
Attachments
Patch (30.82 KB, patch)
2011-03-15 11:47 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (31.00 KB, patch)
2011-03-15 12:10 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (42.81 KB, patch)
2011-03-15 15:27 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-03-15 11:47:32 PDT
Created attachment 85835 [details] Patch
Oliver Hunt
Comment 2 2011-03-15 12:10:28 PDT
Created attachment 85840 [details] Patch updated to tot
WebKit Review Bot
Comment 3 2011-03-15 12:13:29 PDT
Attachment 85840 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSONObject.cpp:87: The parameter name "globalData" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/collector/handles/Local.h:30: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/collector/handles/HandleStack.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 4 2011-03-15 12:31:57 PDT
Attachment 85840 [details] did not build on qt: Build output: http://queues.webkit.org/results/8177633
Build Bot
Comment 5 2011-03-15 14:34:24 PDT
Attachment 85840 [details] did not build on win: Build output: http://queues.webkit.org/results/8183234
Oliver Hunt
Comment 6 2011-03-15 15:27:37 PDT
Created attachment 85862 [details] Patch A few more fixes
Early Warning System Bot
Comment 7 2011-03-15 15:40:13 PDT
Attachment 85862 [details] did not build on qt: Build output: http://queues.webkit.org/results/8175778
Geoffrey Garen
Comment 8 2011-03-15 15:41:32 PDT
Comment on attachment 85862 [details] Patch r=me, assuming the build is OK.
Oliver Hunt
Comment 9 2011-03-15 16:13:01 PDT
Committed r81188: <http://trac.webkit.org/changeset/81188>
WebKit Review Bot
Comment 10 2011-03-15 23:56:49 PDT
http://trac.webkit.org/changeset/81188 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.