Bug 56394 - Introduce Local<T> to allow us to start moving to precise marking of locals
Summary: Introduce Local<T> to allow us to start moving to precise marking of locals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 11:42 PDT by Oliver Hunt
Modified: 2011-03-15 23:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (30.82 KB, patch)
2011-03-15 11:47 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (31.00 KB, patch)
2011-03-15 12:10 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (42.81 KB, patch)
2011-03-15 15:27 PDT, Oliver Hunt 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-03-15 11:42:50 PDT 
Introduce Local<T> to allow us to start moving to precise marking of locals
Comment 1 Oliver Hunt 2011-03-15 11:47:32 PDT 
Created attachment 85835 [details]
Patch
Comment 2 Oliver Hunt 2011-03-15 12:10:28 PDT 
Created attachment 85840 [details]
Patch

updated to tot
Comment 3 WebKit Review Bot 2011-03-15 12:13:29 PDT 
Attachment 85840 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/JSONObject.cpp:87:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/collector/handles/Local.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/collector/handles/HandleStack.cpp:28:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2011-03-15 12:31:57 PDT 
Attachment 85840 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8177633
Comment 5 Build Bot 2011-03-15 14:34:24 PDT 
Attachment 85840 [details] did not build on win:
Build output: http://queues.webkit.org/results/8183234
Comment 6 Oliver Hunt 2011-03-15 15:27:37 PDT 
Created attachment 85862 [details]
Patch

A few more fixes
Comment 7 Early Warning System Bot 2011-03-15 15:40:13 PDT 
Attachment 85862 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8175778
Comment 8 Geoffrey Garen 2011-03-15 15:41:32 PDT 
Comment on attachment 85862 [details]
Patch

r=me, assuming the build is OK.
Comment 9 Oliver Hunt 2011-03-15 16:13:01 PDT 
Committed r81188: <http://trac.webkit.org/changeset/81188>
Comment 10 WebKit Review Bot 2011-03-15 23:56:49 PDT 
http://trac.webkit.org/changeset/81188 might have broken WinCE Release (Build)