Bug 56390 – Valgrind error due to uninitialized PluginLayerChromium::m_textureId

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Alok Priyadarshi]

Valgrind generates the following error due to uninitialized PluginLayerChromium::m_textureId variable:

UninitCondition
Conditional jump or move depends on uninitialised value(s)
  WebKit::WebPluginContainerImpl::platformLayer() const (third_party/WebKit/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:446)
  WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing() const (third_party/WebKit/Source/WebCore/rendering/RenderEmbeddedObject.cpp:107)
  WebCore::RenderEmbeddedObject::requiresLayer() const (third_party/WebKit/Source/WebCore/rendering/RenderEmbeddedObject.cpp:102)
  WebCore::RenderObject::adjustStyleDifference(WebCore::StyleDifference, unsigned int) const (third_party/WebKit/Source/WebCore/rendering/RenderObject.cpp:1708)
  WebCore::RenderObject::setStyle(WTF::PassRefPtr<WebCore::RenderStyle>) (third_party/WebKit/Source/WebCore/rendering/RenderObject.cpp:1738)
  WebCore::RenderObject::setAnimatableStyle(WTF::PassRefPtr<WebCore::RenderStyle>) (third_party/WebKit/Source/WebCore/rendering/RenderObject.cpp:1676)
  WebCore::Node::setRenderStyle(WTF::PassRefPtr<WebCore::RenderStyle>) (third_party/WebKit/Source/WebCore/dom/Node.cpp:1482)
  WebCore::Element::recalcStyle(WebCore::Node::StyleChange) (third_party/WebKit/Source/WebCore/dom/Element.cpp:1089)
  WebCore::HTMLPlugInImageElement::recalcStyle(WebCore::Node::StyleChange) (third_party/WebKit/Source/WebCore/html/HTMLPlugInImageElement.cpp:129)
  WebCore::Element::recalcStyle(WebCore::Node::StyleChange) (third_party/WebKit/Source/WebCore/dom/Element.cpp:1113)
  WebCore::Element::recalcStyle(WebCore::Node::StyleChange) (third_party/WebKit/Source/WebCore/dom/Element.cpp:1113)
  WebCore::Document::recalcStyle(WebCore::Node::StyleChange) (third_party/WebKit/Source/WebCore/dom/Document.cpp:1526)
  WebCore::Document::updateStyleIfNeeded() (third_party/WebKit/Source/WebCore/dom/Document.cpp:1576)
  WebCore::Document::styleRecalcTimerFired(WebCore::Timer<WebCore::Document>*) (third_party/WebKit/Source/WebCore/dom/Document.cpp:1477)

[Alok Priyadarshi]

Created attachment 85834 [details]
proposed patch

Initialized member variable and also addressed your comment about function naming.

[WebKit Commit Bot]

Comment on attachment 85834 [details]
proposed patch

Rejecting attachment 85834 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
ching file Source/WebKit/chromium/public/WebPlugin.h
Hunk #1 FAILED at 64.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/public/WebPlugin.h.rej
patching file Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Hunk #2 FAILED at 443.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/src/WebPluginContainerImpl.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'James Robinson', u'--f..." exit_code: 1

Full output: http://queues.webkit.org/results/8178621

[Alok Priyadarshi]

Created attachment 85837 [details]
proposed patch

Sorry the last patch also included changes from an earlier CL. Now from the correct client.

[WebKit Review Bot]

Attachment 85837 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:72:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:73:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:75:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:76:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:77:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:80:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:81:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Robinson]

Comment on attachment 85837 [details]
proposed patch

wrong patch

[Alok Priyadarshi]

Created attachment 85838 [details]
proposed patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 85838 [details]:

transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 85838 [details]
proposed patch

Clearing flags on attachment: 85838

Committed r81169: <http://trac.webkit.org/changeset/81169>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.