Bug 56379 – WK2: Need to propagate enhanced accessibility flag from UI -> web process

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

The enhanced accessibility flag needs to be propagated from the UI process to the web process.

[chris fleizach]

Created attachment 85813 [details]
patch

[WebKit Review Bot]

Attachment 85813 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/WebProcess/WebProcess.cpp:54:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 85876 [details]
patch

[Darin Adler]

Comment on attachment 85876 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85876&action=review

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:44
> +void WebContet::platformInvalidateContext()

Typo: WebContet.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:40
> +NSString *NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification = @"NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification";

This should be marked “static” so it gets internal linkage since it’s only used within this file. Also, it’s not appropriate to use an NS prefix on something inside WebKit, because it could conflict with something in the underlying framework, so the constant’s name should not have the NS prefix, even if the string should.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:107
> +    m_enhancedAccessibilityObserver = (CFTypeRef)[[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *note) {
> +        setEnhancedAccessibility([[[note userInfo] objectForKey:@"AXEnhancedUserInterface"] boolValue]);
> +    }];

You should not need a cast to CFTypeRef.

[chris fleizach]

http://trac.webkit.org/changeset/81274