Bug 56378 – Enhancement: New Script to Format malloc_history output as tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Saboff]

Add a script to process the output from MacOS malloc_history output to hierarchical tree format.

[Michael Saboff]

Created attachment 85812 [details]
New script to process malloc_history output to tree format

[Eric Seidel (no email)]

Comment on attachment 85812 [details]
New script to process malloc_history output to tree format

View in context: https://bugs.webkit.org/attachment.cgi?id=85812&action=review

This seems OK.  It's written as a one-off w/o much re-use in mind, which is kinda the opposite of how I try to write python. :)  I think this could use another round of cleanup to make this more hackable for others in the future.

I'm glad you're adding this though. :)

> Tools/Scripts/malloc-tree:60
> +

I think pep8 says two spaces between globals, but I could be wrong.

> Tools/Scripts/malloc-tree:102
> +    def printNode(self, prefix = ' '):
> +        global hotspot
> +        global scaleSize
> +        global showBars

Seems this could just take an options object instead of using globals.

> Tools/Scripts/malloc-tree:137
> +def main():

I would have broken this up into smaller functions.

> Tools/Scripts/malloc-tree:163
> +        if hotspot:
> +            scaleSize = False
> +        else:
> +            scaleSize = True

Seems long-winded.

[Eric Seidel (no email)]

Comment on attachment 85812 [details]
New script to process malloc_history output to tree format

In general this is fine.  We should land this and iterate.

[WebKit Review Bot]

Comment on attachment 85812 [details]
New script to process malloc_history output to tree format

Clearing flags on attachment: 85812

Committed r89195: <http://trac.webkit.org/changeset/89195>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.