Bug 56374 - HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element if it's an internal pause for example.
Summary: HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "publ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 07:48 PDT by Alexis Menard (darktears)
Modified: 2011-05-04 12:59 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch. (1.33 KB, patch)
2011-03-15 07:51 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
updated Changelog. (1.36 KB, patch)
2011-03-15 08:01 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-03-15 07:48:15 PDT 
In case of an internal pause (i.e. it's not reflected in the DOM) the callback HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the state of the element. We should not call playInternal or pauseInternal because they can change the status of the element.
Comment 1 Alexis Menard (darktears) 2011-03-15 07:51:16 PDT 
Created attachment 85804 [details]
Proposed patch.
Comment 2 Alexis Menard (darktears) 2011-03-15 08:01:58 PDT 
Created attachment 85805 [details]
updated Changelog.
Comment 3 WebKit Commit Bot 2011-03-15 10:32:44 PDT 
Comment on attachment 85805 [details]
updated Changelog.

Clearing flags on attachment: 85805

Committed r81145: <http://trac.webkit.org/changeset/81145>
Comment 4 WebKit Commit Bot 2011-03-15 10:32:47 PDT 
All reviewed patches have been landed.  Closing bug.