Bug 56370 - [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
Summary: [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 03:28 PDT by Philippe Normand
Modified: 2011-03-16 10:25 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (3.53 KB, patch)
2011-03-15 04:54 PDT, Philippe Normand 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-03-15 03:28:15 PDT 
Diff:

--- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/media/video-play-stall-before-meta-data-expected.txt	2011-03-15 03:05:36.457251353 -0700
+++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/media/video-play-stall-before-meta-data-actual.txt	2011-03-15 03:05:36.457251353 -0700
@@ -2,7 +2,6 @@
 
 EVENT(beforeload)
 EVENT(loadstart)
-EVENT(stalled)
 EVENT(window.onload)
 END OF TEST

I think the test fails because our player errors out and resets its network state too early, preventing HTMLMediaElement::progressEventTimerFired to emit the stalled event.

I'll skip the test on GTK for now and work on a fix for this issue.
Comment 1 Philippe Normand 2011-03-15 03:38:00 PDT 
Skipped in http://trac.webkit.org/changeset/81125
Comment 2 Philippe Normand 2011-03-15 04:54:34 PDT 
Created attachment 85796 [details]
proposed patch
Comment 3 Philippe Normand 2011-03-16 01:57:28 PDT 
Committed r81229: <http://trac.webkit.org/changeset/81229>
Comment 4 Joseph Pecoraro 2011-03-16 10:25:31 PDT 
Thanks for fixing this Philippe. I didn't even notice it failed on gtk.