Bug 56364 - Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Summary: Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ilya Sherman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 23:57 PDT by Ilya Sherman
Modified: 2011-03-21 20:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2011-03-14 23:58 PDT, Ilya Sherman 		no flags Details | Formatted Diff | Diff
Patch (2.14 KB, patch)
2011-03-18 15:27 PDT, Ilya Sherman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Sherman 2011-03-14 23:57:16 PDT 
Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Comment 1 Ilya Sherman 2011-03-14 23:58:09 PDT 
Created attachment 85782 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-15 00:05:54 PDT 
Attachment 85782 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8174522
Comment 3 Ilya Sherman 2011-03-15 00:40:36 PDT 
(In reply to comment #2)
> Attachment 85782 [details] did not build on chromium:
> Build output: http://queues.webkit.org/results/8174522

The file that's triggering this compile error is stale -- it doesn't exist anymore in the Chromium repository as of crrev.com/77840  Adam Barth suggested that I should update the Source/WebKit/chromium/DEPS file, but Dave Levin mentioned that this file can't be rolled right now due to a potentially inadvertently added dependency.  So... guess I'll just wait for now and let that get sorted out =)
Comment 4 Eric Seidel (no email) 2011-03-18 15:03:22 PDT 
Comment on attachment 85782 [details]
Patch

Looks like cr-linux is sad?
Comment 5 Ilya Sherman 2011-03-18 15:27:20 PDT 
Created attachment 86227 [details]
Patch
Comment 6 Ilya Sherman 2011-03-18 15:28:06 PDT 
Rebased; cr-linux should cheer right up
Comment 7 Ilya Sherman 2011-03-21 15:57:41 PDT 
Ping :)
Comment 8 James Robinson 2011-03-21 16:06:59 PDT 
Comment on attachment 86227 [details]
Patch

I always like removing API!
Comment 9 WebKit Commit Bot 2011-03-21 20:06:39 PDT 
Comment on attachment 86227 [details]
Patch

Clearing flags on attachment: 86227

Committed r81637: <http://trac.webkit.org/changeset/81637>
Comment 10 WebKit Commit Bot 2011-03-21 20:06:42 PDT 
All reviewed patches have been landed.  Closing bug.