NEW 56347
WebKit should reset the click count when a new page loads.
https://bugs.webkit.org/show_bug.cgi?id=56347
Summary WebKit should reset the click count when a new page loads.
Luiz Agostini
Reported 2011-03-14 17:58:25 PDT
Some tests are failing in Windows apparently because clicks in sequential tests are sometimes counted as double clicks.
Attachments
Work-in-progress patch for WebKit1 (6.69 KB, patch)
2011-05-27 11:37 PDT, Adam Roben (:aroben)
no flags
Luiz Agostini
Comment 1 2011-03-14 18:16:46 PDT
The following tests were skipped in Windows: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-10-and-click.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-6-and-click.html
Jessie Berlin
Comment 2 2011-04-12 13:57:31 PDT
Adam Roben (:aroben)
Comment 3 2011-05-24 10:04:48 PDT
In WebKit1, WebView::handleMouseEvent has a globalClickCount variable that is responsible for this. In WebKit2, WebEventFactor.cpp has a clickCount function that stores a gLastClickCount variable.
Adam Roben (:aroben)
Comment 4 2011-05-27 11:37:34 PDT
Created attachment 95201 [details] Work-in-progress patch for WebKit1 Here's a work-in-progress patch for WebKit1. It doesn't try to fix WebKit2.
Ryosuke Niwa
Comment 5 2011-10-07 15:39:51 PDT
*** Bug 61633 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Comment 6 2011-10-07 15:42:25 PDT
This is causing Windows port to lose a significant test coverage. We need to fix it ASAP.
Brent Fulgham
Comment 7 2014-02-18 11:30:46 PST
This no longer seems to be a problem on Windows; all of these tests pass. Perhaps this is because WK2 is no longer used on Windows?
Note You need to log in before you can comment on or make changes to this bug.