Bug 56335 - [chromium] add a build target to create a grd file with devtool resources
Summary: [chromium] add a build target to create a grd file with devtool resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 14:11 PDT by Tony Chang
Modified: 2011-03-15 14:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.10 KB, patch)
2011-03-14 14:12 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (7.41 KB, patch)
2011-03-15 13:37 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-03-14 14:11:25 PDT 
[chromium] add a build target to create a grd file with devtool resources
Comment 1 Tony Chang 2011-03-14 14:12:13 PDT 
Created attachment 85717 [details]
Patch
Comment 2 Tony Chang 2011-03-14 14:15:04 PDT 
This is the webkit side of http://code.google.com/p/chromium/issues/detail?id=35793 .  The next chromium side that uses this is: http://codereview.chromium.org/6685061/


In general, the plan is to put all the files in resources/inspector into resources.pak.  To do that, we generate the .grd file with this script, then we run grit on the file which creates devtools.pak which we then merge (repack) into resources.pak.

The chromium code will also have to be updated to load the files from resources.pak.  Also, this shouldn't change anything for test_shell, DRT or for the debug mode.
Comment 3 Adam Barth 2011-03-15 02:15:31 PDT 
Comment on attachment 85717 [details]
Patch

Crazy.  The Python script is very nice.  WebKit.gyp is out of control.
Comment 4 Tony Chang 2011-03-15 10:41:07 PDT 
Committed r81147: <http://trac.webkit.org/changeset/81147>
Comment 5 Tony Chang 2011-03-15 10:57:09 PDT 
Broke on Chromium Win so I reverted: http://trac.webkit.org/changeset/81152
Comment 6 Tony Chang 2011-03-15 10:57:26 PDT 
reopening
Comment 7 Tony Chang 2011-03-15 13:37:52 PDT 
Created attachment 85852 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2011-03-15 14:37:21 PDT 
Comment on attachment 85852 [details]
Patch for landing

Clearing flags on attachment: 85852

Committed r81175: <http://trac.webkit.org/changeset/81175>
Comment 9 WebKit Commit Bot 2011-03-15 14:37:29 PDT 
All reviewed patches have been landed.  Closing bug.