WebCore actually called IconDatabaseBase::defaultIcon() internally, just to support HistoryItem::icon(), which was only used to support API in a non-maintained WebKit port. Let's remove that nonsense.
Created attachment 85695 [details] Patch v1
Attachment 85695 [details] did not build on qt: Build output: http://queues.webkit.org/results/8174348
Ahhah, qt is using it to! New patch coming...
Created attachment 85698 [details] Patch v2 - Fix Qt also
Attachment 85698 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/qt/Api/qwebhistory.cpp:27: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 85698 [details] did not build on qt: Build output: http://queues.webkit.org/results/8174354
Created attachment 85701 [details] Patch v3 - "Better" Qt fix
r81058
http://trac.webkit.org/changeset/81058 might have broken EFL Linux Release (Build)
(In reply to comment #9) > http://trac.webkit.org/changeset/81058 might have broken EFL Linux Release (Build) Sure would suck if it did, because the EFL EWS bot said it was fine! :)
(In reply to comment #10) > (In reply to comment #9) > > http://trac.webkit.org/changeset/81058 might have broken EFL Linux Release (Build) > > Sure would suck if it did, because the EFL EWS bot said it was fine! :) It did - http://build.webkit.org/builders/EFL%20Linux%20Release%20%28Build%29/builds/9596/steps/compile-webkit/logs/stdio What use is the EWS if it's not in line with what the build bot will see?
> What use is the EWS if it's not in line with what the build bot will see? That's a good question. We should follow up with the folks who run the EFL EWS bot.
Attempted EFL build fix in r81060