RESOLVED FIXED 56310
Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js 
https://bugs.webkit.org/show_bug.cgi?id=56310
Summary Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CS...
Alexander Pavlov (apavlov)
Reported Monday, March 14, 2011 4:16:57 PM UTC
The current implementation: 1. Does not follow the setStyleSheetText() call result specified by the protocol (should be a boolean instead of stylesheet payload) 2. Does not dispatch the "stylesheet changed" event
Attachments
[PATCH] Suggested fix (2.84 KB, patch)
2011-03-14 08:28 PDT, Alexander Pavlov (apavlov) 		pfeldman: review-
pfeldman: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Test added (9.76 KB, patch)
2011-03-14 09:25 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Comments addressed (14.94 KB, patch)
2011-03-15 09:51 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] Style fixed (23.42 KB, patch)
2011-03-15 11:35 PDT, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 Monday, March 14, 2011 4:28:49 PM UTC
Created attachment 85678 [details] [PATCH] Suggested fix
Pavel Feldman
Comment 2 Monday, March 14, 2011 4:34:35 PM UTC
Comment on attachment 85678 [details] [PATCH] Suggested fix Please add a test.
Alexander Pavlov (apavlov)
Comment 3 Monday, March 14, 2011 5:25:47 PM UTC
Created attachment 85684 [details] [PATCH] Test added
Pavel Feldman
Comment 4 Monday, March 14, 2011 6:04:40 PM UTC
Comment on attachment 85684 [details] [PATCH] Test added View in context: https://bugs.webkit.org/attachment.cgi?id=85684&action=review > LayoutTests/inspector/styles/styles-stylesheet-text.html:1 > +<html> can be get-set-stylesheet-text.html > LayoutTests/inspector/styles/styles-stylesheet-text.html:24 > + function test_findStyleSheet(error, styleSheetIds) use InspectorTest.runTestSuite for the reset instead. Also, I think getAllStyles should be called getAllStyleSheets and return stylesheet metainfo ('url' for now) along with its id.
Alexander Pavlov (apavlov)
Comment 5 Tuesday, March 15, 2011 5:51:19 PM UTC
Created attachment 85819 [details] [PATCH] Comments addressed
WebKit Review Bot
Comment 6 Tuesday, March 15, 2011 5:53:28 PM UTC
Attachment 85819 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InspectorCSSAgent.h:67: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexander Pavlov (apavlov)
Comment 7 Tuesday, March 15, 2011 7:35:40 PM UTC
Created attachment 85832 [details] [PATCH] Style fixed
WebKit Review Bot
Comment 8 Friday, March 18, 2011 7:38:43 PM UTC
http://trac.webkit.org/changeset/81487 might have broken Leopard Intel Release (Tests) The following tests are not passing: inspector/styles/styles-add-blank-property.html
WebKit Review Bot
Comment 9 Friday, March 25, 2011 1:21:01 PM UTC
http://trac.webkit.org/changeset/81953 might have broken GTK Linux 32-bit Release The following tests are not passing: inspector/styles/styles-add-blank-property.html
Alexander Pavlov (apavlov)
Comment 10 Tuesday, March 29, 2011 4:39:03 PM UTC
Landed with a flakiness fix for LayoutTests/inspector/styles/styles-add-blank-property.html from bug 57252. Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/inspector/styles/get-set-stylesheet-text-expected.txt A LayoutTests/inspector/styles/get-set-stylesheet-text.html A LayoutTests/inspector/styles/resources/get-set-stylesheet-text.css M LayoutTests/inspector/styles/styles-add-blank-property.html M LayoutTests/inspector/styles/styles-new-API.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/Inspector.json M Source/WebCore/inspector/InspectorCSSAgent.cpp M Source/WebCore/inspector/InspectorCSSAgent.h M Source/WebCore/inspector/InspectorStyleSheet.cpp M Source/WebCore/inspector/InspectorStyleSheet.h M Source/WebCore/inspector/front-end/AuditRules.js M Source/WebCore/inspector/front-end/CSSStyleModel.js Committed r82252
Note You need to log in before you can comment on or make changes to this bug.