Bug 56306 - JavaMethod.cpp does not compile with V8
Summary: JavaMethod.cpp does not compile with V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 06:43 PDT by Steve Block
Modified: 2011-03-14 10:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2011-03-14 08:10 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2011-03-14 06:43:36 PDT
Code in bridge/jni is used with both JSC and V8 (on Android). The compile error is because JavaMethod.cpp includes the JSC-specific header ScopeChain.h. This was introduced in http://trac.webkit.org/changeset/79904 (when the file was called JNIBridge.cpp)
Comment 1 Steve Block 2011-03-14 08:10:34 PDT
Created attachment 85675 [details]
Patch
Comment 2 Oliver Hunt 2011-03-14 08:43:52 PDT
Comment on attachment 85675 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2011-03-14 10:39:36 PDT
Comment on attachment 85675 [details]
Patch

Clearing flags on attachment: 85675

Committed r81036: <http://trac.webkit.org/changeset/81036>
Comment 4 WebKit Commit Bot 2011-03-14 10:39:40 PDT
All reviewed patches have been landed.  Closing bug.