RESOLVED FIXED 56305
Web Inspector: refactor event listener breakpoints. 
https://bugs.webkit.org/show_bug.cgi?id=56305
Summary Web Inspector: refactor event listener breakpoints.
Pavel Podivilov
Reported 2011-03-14 05:22:05 PDT
Web Inspector: refactor event listener breakpoints. - restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints - store event listener breakpoints in a separate separate setting - move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane
Attachments
Patch. (39.09 KB, patch)
2011-03-14 05:23 PDT, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-14 05:23:09 PDT
Created attachment 85667 [details] Patch.
Yury Semikhatsky
Comment 2 2011-03-15 02:36:20 PDT
Comment on attachment 85667 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=85667&action=review > LayoutTests/inspector/debugger/event-listener-breakpoints.html:19 > + element.dispatchEvent(event); Can you use element.click() instead? > Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp:123 > + return; You should return error string here, I believe. Same for the methods below. > Source/WebCore/inspector/front-end/BreakpointManager.js:84 > + BrowserDebuggerAgent.setEventListenerBreakpoint(eventName); I'd probably inline this method.
Pavel Podivilov
Comment 3 2011-03-16 08:09:33 PDT
Committed r81243: <http://trac.webkit.org/changeset/81243>
Pavel Podivilov
Comment 4 2011-03-17 08:56:40 PDT
Committed r81355: <http://trac.webkit.org/changeset/81355>
Note You need to log in before you can comment on or make changes to this bug.