Clean up includes/forward declarations in IconDatabaseBase It'd be great to get rid of the "PlatformString.h" include.
Created attachment 85657 [details] Patch v1
Attachment 85657 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/icon/IconDatabaseBase.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 85686 [details] Patch v2 - Left out the WebKit pieces
Ignore the "Left out the WebKit pieces" in the patch title - autocomplete, damn you!
Comment on attachment 85686 [details] Patch v2 - Left out the WebKit pieces View in context: https://bugs.webkit.org/attachment.cgi?id=85686&action=review > Source/WebCore/loader/icon/IconDatabase.h:31 > +#include "PlatformString.h" This should be <wtf/text/WTFString.h> > Source/WebCore/loader/icon/IconDatabaseBase.h:34 > +namespace WTF { > +class String; > +} This should use <wtf/Forward.h> > Source/WebCore/loader/icon/IconDatabaseBase.h:97 > + virtual WTF::String databasePath() const; If you use forward.h, the WTF is not necessary.
Created attachment 85688 [details] Patch v3
http://trac.webkit.org/projects/webkit/changeset/81034