Bug 56285 – StorageTracker - lock fixes - followup for feedback on https://bugs.webkit.org/show_bug.cgi?id=51878

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Anton D'Auria]

The primary patch for https://bugs.webkit.org/show_bug.cgi?id=51878 has already been checked in. To simplify discussion of lock-related fixes in StorageTracker, I am opening this bug. A patch for this bug should address all issues brought up by David Levin here: https://bugs.webkit.org/show_bug.cgi?id=51878#c93

[Anton D'Auria]

Created attachment 85640 [details]
Patch

StorageTracker::scheduleTask() was correct but not very readable.

[David Levin]

I would have liked to have had a chance to review this since it is addressing my comments :( 

There were already several mistakes in previous iterations which I caught.

[Brady Eidson]

(In reply to comment #2)
> I would have liked to have had a chance to review this since it is addressing my comments :( 
> 
> There were already several mistakes in previous iterations which I caught.

Sorry about that, such a desire wasn't present in this bug.  You're still allowed to review - bonus points if it's tonight...  :)

[David Levin]

Comment on attachment 85640 [details]
Patch

Looks fine to me too. Thanks for waiting. I just wanted to see this through and do my best to verify correctness.

Hopefully this will help you in the end. (I caught several issues which could have led to instability here.)

[Brady Eidson]

Comment on attachment 85640 [details]
Patch

Landing manually to help some colleagues get at it before the commit queue wakes up.

[Brady Eidson]

landed in r81003