RESOLVED FIXED 56283
A few Heap-related renames (sans file moves, which should come next) 
https://bugs.webkit.org/show_bug.cgi?id=56283
Summary A few Heap-related renames (sans file moves, which should come next)
Geoffrey Garen
Reported 2011-03-13 19:00:07 PDT
A few Heap-related renames (sans file moves, which should come next)
Attachments
Patch (20.60 KB, patch)
2011-03-13 19:07 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (21.70 KB, patch)
2011-03-13 20:38 PDT, Geoffrey Garen 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-03-13 19:07:29 PDT
Created attachment 85633 [details] Patch
WebKit Review Bot
Comment 2 2011-03-13 19:09:48 PDT
Attachment 85633 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/APIShims.h', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/MachineStackMarker.h:22: #ifndef header guard has wrong style, please use: WTF_MachineStackMarker_h [build/header_guard] [5] Source/JavaScriptCore/runtime/ConservativeSet.h:26: #ifndef header guard has wrong style, please use: WTF_ConservativeSet_h [build/header_guard] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2011-03-13 20:36:30 PDT
Attachment 85633 [details] did not build on win: Build output: http://queues.webkit.org/results/8174155
Build Bot
Comment 4 2011-03-13 20:37:03 PDT
Attachment 85633 [details] did not build on win: Build output: http://queues.webkit.org/results/8179101
Geoffrey Garen
Comment 5 2011-03-13 20:38:33 PDT
Created attachment 85638 [details] Patch
WebKit Review Bot
Comment 6 2011-03-13 20:41:12 PDT
Attachment 85638 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/APIShims.h', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/MachineStackMarker.h:22: #ifndef header guard has wrong style, please use: WTF_MachineStackMarker_h [build/header_guard] [5] Source/JavaScriptCore/runtime/ConservativeSet.h:26: #ifndef header guard has wrong style, please use: WTF_ConservativeSet_h [build/header_guard] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7 2011-03-13 21:53:21 PDT
Attachment 85633 [details] did not build on mac: Build output: http://queues.webkit.org/results/8181074
Geoffrey Garen
Comment 8 2011-03-13 21:54:12 PDT
Comment on attachment 85638 [details] Patch Sam reviewed this.
Geoffrey Garen
Comment 9 2011-03-13 21:57:26 PDT
Committed revision 80995.
Note You need to log in before you can comment on or make changes to this bug.