Bug 56283 - A few Heap-related renames (sans file moves, which should come next)
Summary: A few Heap-related renames (sans file moves, which should come next)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-13 19:00 PDT by Geoffrey Garen
Modified: 2011-03-13 21:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (20.60 KB, patch)
2011-03-13 19:07 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (21.70 KB, patch)
2011-03-13 20:38 PDT, Geoffrey Garen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-03-13 19:00:07 PDT 
A few Heap-related renames (sans file moves, which should come next)
Comment 1 Geoffrey Garen 2011-03-13 19:07:29 PDT 
Created attachment 85633 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-13 19:09:48 PDT 
Attachment 85633 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/APIShims.h', u'S..." exit_code: 1

Source/JavaScriptCore/runtime/MachineStackMarker.h:22:  #ifndef header guard has wrong style, please use: WTF_MachineStackMarker_h  [build/header_guard] [5]
Source/JavaScriptCore/runtime/ConservativeSet.h:26:  #ifndef header guard has wrong style, please use: WTF_ConservativeSet_h  [build/header_guard] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2011-03-13 20:36:30 PDT 
Attachment 85633 [details] did not build on win:
Build output: http://queues.webkit.org/results/8174155
Comment 4 Build Bot 2011-03-13 20:37:03 PDT 
Attachment 85633 [details] did not build on win:
Build output: http://queues.webkit.org/results/8179101
Comment 5 Geoffrey Garen 2011-03-13 20:38:33 PDT 
Created attachment 85638 [details]
Patch
Comment 6 WebKit Review Bot 2011-03-13 20:41:12 PDT 
Attachment 85638 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/APIShims.h', u'S..." exit_code: 1

Source/JavaScriptCore/runtime/MachineStackMarker.h:22:  #ifndef header guard has wrong style, please use: WTF_MachineStackMarker_h  [build/header_guard] [5]
Source/JavaScriptCore/runtime/ConservativeSet.h:26:  #ifndef header guard has wrong style, please use: WTF_ConservativeSet_h  [build/header_guard] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2011-03-13 21:53:21 PDT 
Attachment 85633 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8181074
Comment 8 Geoffrey Garen 2011-03-13 21:54:12 PDT 
Comment on attachment 85638 [details]
Patch

Sam reviewed this.
Comment 9 Geoffrey Garen 2011-03-13 21:57:26 PDT 
Committed revision 80995.