Bug 56279 - Add ability to create a WKErrorRef
Summary: Add ability to create a WKErrorRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-13 17:28 PDT by Sam Weinig
Modified: 2011-03-13 18:00 PDT (History)
3 users (show)

See Also:


Attachments
Patch (21.81 KB, patch)
2011-03-13 17:31 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-03-13 17:28:52 PDT
Add ability to create a WKErrorRef
Comment 1 Sam Weinig 2011-03-13 17:31:43 PDT
Created attachment 85629 [details]
Patch
Comment 2 Sam Weinig 2011-03-13 17:34:58 PDT
Landed in r80981.
Comment 3 WebKit Review Bot 2011-03-13 17:35:07 PDT
Attachment 85629 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:130:  Missing space before ( in switch(  [whitespace/parens] [5]
Source/WebCore/platform/network/cf/ResourceError.h:58:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/network/cf/ResourceError.h:64:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/API/c/cf/WKErrorCF.h:36:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/API/c/cf/WKErrorCF.h:37:  The parameter name "alloc" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/Shared/API/c/cf/WKErrorCF.h:37:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2011-03-13 18:00:49 PDT
http://trac.webkit.org/changeset/80981 might have broken Windows Release (Build) and Windows Debug (Build)