Bug 56273 - Add three operand forms to MacroAssember operations.
Summary: Add three operand forms to MacroAssember operations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-13 14:59 PDT by Gavin Barraclough
Modified: 2011-03-13 15:12 PDT (History)
1 user (show)

See Also:


Attachments
The patch (24.98 KB, patch)
2011-03-13 15:00 PDT, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-03-13 14:59:00 PDT
Adding for X86(_64) for now, should be rolled out to other backends as necessary.  These may allow more efficient code generation in some cases, avoiding the need for unnecessary register-register move instructions.
Comment 1 Gavin Barraclough 2011-03-13 15:00:38 PDT
Created attachment 85624 [details]
The patch

Also adds a non-expilicit constructor to FunctionPtr, and an isSet method to Jump.
Comment 2 WebKit Review Bot 2011-03-13 15:02:14 PDT
Attachment 85624 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/X86Assembler.h:1403:  movsd_rr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:106:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:174:  shift_amount is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:179:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:289:  shift_amount is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:294:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:326:  shift_amount is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:331:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-03-13 15:12:22 PDT
fixed in r80972