RESOLVED FIXED 5626
REGRESSION: float element with bottom padding and negative margin overlaps subsequent elements 
https://bugs.webkit.org/show_bug.cgi?id=5626
Summary REGRESSION: float element with bottom padding and negative margin overlaps su...
Brad Fults
Reported 2005-11-04 09:33:06 PST
See the testcase URL: http://xkr.us/bugs/safari-05-002.html
Attachments
Reduced testcase (1.92 KB, text/html)
2005-11-04 09:35 PST, Brad Fults 		sullivan: review+
Details
Reduced Testcase/variation (802 bytes, text/html)
2005-11-04 09:43 PST, Daniel Udey 		no flags
Details
Patch that fixes the ghosted float problem (1.50 KB, patch)
2005-11-04 12:50 PST, Dave Hyatt 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brad Fults
Comment 1 2005-11-04 09:35:58 PST
Created attachment 4594 [details] Reduced testcase
Daniel Udey
Comment 2 2005-11-04 09:43:55 PST
Created attachment 4595 [details] Reduced Testcase/variation The bug is arising because floating elements with a specific size (including padding) are not constrained by their enclosing elements even if overflow: hidden; is set. The object is constrained visually, but the layout still considers the box to be there for the purposes of user input, and as such, it captures clicks, preventing them from being passed to the elements 'below'. In this testcase, an onclick event was added to the inner div. When the input is clicked on, the onclick event in the inner div fires instead.
Dave Hyatt
Comment 3 2005-11-04 12:50:13 PST
Created attachment 4599 [details] Patch that fixes the ghosted float problem This patch makes sure floatRect will just return the border box if an overflow clip is in effect. It also further optimizes event handling and painting by making sure that phases other than the float phase don't even need to check floats (and can possibly short circuit much earlier as a result).
Dave Hyatt
Comment 4 2005-11-04 12:52:03 PST
This is a regression from Safari 1.2.
Dave Hyatt
Comment 5 2005-11-04 13:12:24 PST
Fixed.
Darin Adler
Comment 6 2005-11-05 08:06:51 PST
Comment on attachment 4599 [details] Patch that fixes the ghosted float problem Dave already landed this.
Daniel Udey
Comment 7 2005-11-09 07:07:30 PST
*** Bug 3254 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.