Bug 56257 - WebCore fails to build with Clang on ARM
Summary: WebCore fails to build with Clang on ARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-12 17:51 PST by Cameron Zwarich (cpst)
Modified: 2011-03-12 19:33 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch (3.64 KB, patch)
2011-03-12 17:53 PST, Cameron Zwarich (cpst)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2011-03-12 17:51:36 PST
/Volumes/Data/WebKit/Source/WebCore/bindings/js/SerializedScriptValue.cpp:460:19: error: shift count >= width of type
            value >>= 8;
                  ^   ~
/Volumes/Data/WebKit/Source/WebCore/bindings/js/SerializedScriptValue.cpp:221:13: note: in instantiation of function template specialization 'WebCore::CloneSerializer::writeLittleEndian<unsigned char>' requested here
            writeLittleEndian<uint8_t>(out, EmptyStringTag);
            ^
1 error generated.

We need to add an explicit specialization, since this is actually used in a lot of places. But you can't add an explicit specialization at class scope, so writeLittleEndian needs to be made a non-member function.
Comment 1 Cameron Zwarich (cpst) 2011-03-12 17:53:57 PST
Created attachment 85603 [details]
Proposed patch
Comment 2 Cameron Zwarich (cpst) 2011-03-12 19:19:15 PST
Fixed in r80949.
Comment 3 WebKit Review Bot 2011-03-12 19:29:01 PST
http://trac.webkit.org/changeset/80949 might have broken Qt Linux Release minimal, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, Qt Windows 32-bit Debug, and EFL Linux Release (Build)
Comment 4 Cameron Zwarich (cpst) 2011-03-12 19:33:01 PST
Ah, the specialization should not have a static.