Bug 56248 - Web Inspector: add tests for edit dom operations.
Summary: Web Inspector: add tests for edit dom operations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-12 05:40 PST by Pavel Feldman
Modified: 2011-03-14 03:18 PDT (History)
13 users (show)

See Also:


Attachments
Patch (6.93 KB, patch)
2011-03-12 05:44 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] A better test + migrated from success flag to errorString in DOM agent. (22.80 KB, patch)
2011-03-12 13:01 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-12 05:40:49 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-03-12 05:44:10 PST
Created attachment 85590 [details]
Patch
Comment 2 Ilya Tikhonovsky 2011-03-12 08:47:00 PST
Comment on attachment 85590 [details]
Patch

lgtm
Comment 3 Pavel Feldman 2011-03-12 13:01:53 PST
Created attachment 85602 [details]
[PATCH] A better test + migrated from success flag to errorString in DOM agent.
Comment 4 Pavel Feldman 2011-03-14 02:42:41 PDT
Comment on attachment 85602 [details]
[PATCH] A better test + migrated from success flag to errorString in DOM agent.

Clearing flags on attachment: 85602

Committed r81009: <http://trac.webkit.org/changeset/81009>
Comment 5 Pavel Feldman 2011-03-14 02:42:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-03-14 03:18:12 PDT
http://trac.webkit.org/changeset/81009 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
inspector/elements/edit-dom-actions.html