Bug 56240 - Invalid assertion in StorageTracker -- PageGroup::numberOfPageGroups() == 1
Summary: Invalid assertion in StorageTracker -- PageGroup::numberOfPageGroups() == 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Anton D'Auria
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 21:04 PST by Anton D'Auria
Modified: 2011-03-14 11:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2011-03-11 23:11 PST, Anton D'Auria 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton D'Auria 2011-03-11 21:04:28 PST 
LocalStorage is currently in limbo. It is accessed through separate PageGroup instances with their own StorageNamespace instances, but each PageGroup uses the same path for LocalStorage dbs. Thus, the in-memory versions of those dbs can be out of sync with the db if another PageGroup is writing to it. This has been brought up in https://bugs.webkit.org/show_bug.cgi?id=51878

LocalStorage should either be truly per-PageGroup, or global. Right now it is neither, so until this is fixed, the assertion in StorageTracker --  (PageGroup::numberOfPageGroups() == 1) -- is invalid.
Comment 1 Anton D'Auria 2011-03-11 21:05:56 PST 
I should have stated explicitly that "the in-memory versions of those dbs" are StorageAreas with their HashMap representations of the backing dbs.
Comment 2 Anton D'Auria 2011-03-11 23:11:00 PST 
Created attachment 85572 [details]
Patch
Comment 3 Brady Eidson 2011-03-13 23:21:15 PDT 
Landed in r81002
Comment 4 Brady Eidson 2011-03-13 23:21:59 PDT 
We should still track actually clearing up the "am I per-pagegroup or not?" concept here.