Bug 56234 - [chromium] Correct return type of WebClipboard::readImage
Summary: [chromium] Correct return type of WebClipboard::readImage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 16:45 PST by Daniel Cheng
Modified: 2011-03-11 17:08 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2011-03-11 16:50 PST, Daniel Cheng
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2011-03-11 16:45:37 PST
Change it from a WebImage to WebData to indicate that we are returning a blob of PNG data.
Comment 1 Daniel Cheng 2011-03-11 16:50:47 PST
Created attachment 85556 [details]
Patch
Comment 2 Tony Chang 2011-03-11 16:58:11 PST
Comment on attachment 85556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review

> Source/WebKit/chromium/public/WebClipboard.h:36
>  #include "WebImage.h"

Can we remove this?
Comment 3 Dmitry Titov 2011-03-11 16:58:50 PST
(In reply to comment #2)
> (From update of attachment 85556 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review
> 
> > Source/WebKit/chromium/public/WebClipboard.h:36
> >  #include "WebImage.h"
> 
> Can we remove this?

Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch
Comment 4 Tony Chang 2011-03-11 17:00:17 PST
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 85556 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review
> > 
> > > Source/WebKit/chromium/public/WebClipboard.h:36
> > >  #include "WebImage.h"
> > 
> > Can we remove this?
> 
> Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch

Looks like we'll have to forward declare WebImage because writeImage uses it, which is fine.
Comment 5 Daniel Cheng 2011-03-11 17:02:39 PST
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 85556 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review
> > > 
> > > > Source/WebKit/chromium/public/WebClipboard.h:36
> > > >  #include "WebImage.h"
> > > 
> > > Can we remove this?
> > 
> > Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch
> 
> Looks like we'll have to forward declare WebImage because writeImage uses it, which is fine.

I will fix this before landing. Thanks!
Comment 6 Daniel Cheng 2011-03-11 17:08:03 PST
Committed r80907: <http://trac.webkit.org/changeset/80907>