RESOLVED FIXED 56223
drag-text-delay.html should be a dump as text test 
https://bugs.webkit.org/show_bug.cgi?id=56223
Summary drag-text-delay.html should be a dump as text test
Ryosuke Niwa
Reported 2011-03-11 14:15:36 PST
drag-text-delay.html currently dumps pixel results and it's hard to verify the correctness of the result. We should convert it to a dump as text test so that regression can more easily be caught.
Attachments
converts the test (13.40 KB, patch)
2011-03-11 14:32 PST, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-03-11 14:32:10 PST
Created attachment 85535 [details] converts the test
Tony Chang
Comment 2 2011-03-11 14:43:38 PST
Comment on attachment 85535 [details] converts the test Looks like gtk will need a new baseline too (looks like they don't remove the space when dragging), but that can be pulled from the gtk bot.
Ryosuke Niwa
Comment 3 2011-03-11 14:55:30 PST
(In reply to comment #2) > (From update of attachment 85535 [details]) > Looks like gtk will need a new baseline too (looks like they don't remove the space when dragging), but that can be pulled from the gtk bot. Ok. Will do. Thanks for the review!
Ryosuke Niwa
Comment 4 2011-03-11 14:55:51 PST
Committed r80889: <http://trac.webkit.org/changeset/80889>
Ryosuke Niwa
Comment 5 2011-03-11 15:25:36 PST
(In reply to comment #2) > (From update of attachment 85535 [details]) > Looks like gtk will need a new baseline too (looks like they don't remove the space when dragging), but that can be pulled from the gtk bot. It seems like we don't need to: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/11572/steps/layout-test/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.