Bug 56214 – Ensure all values are correctly tagged in the registerfile

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Ensure all values are correctly tagged in the registerfile

[Oliver Hunt]

Created attachment 85516 [details]
Patch

[Early Warning System Bot]

Attachment 85516 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8132369

[Oliver Hunt]

Created attachment 85520 [details]
Patch

[Build Bot]

Attachment 85516 [details] did not build on win:
Build output: http://queues.webkit.org/results/8132382

[Gavin Barraclough]

Comment on attachment 85520 [details]
Patch

Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj change should probably be reverted?

> *this = JSValue(reinterpret_cast<JSCell*>(activation));

These casts are all incorrect, they should be static_casts (reinterpret_cast is almost always the wrong cast when casting within a class hierarchy).
But can't you just delete all these overloaded= operators? - why doesn't the compiler just call the operator=(JSValue) automatically?

If we're going to access the two halves of the value like we do in JSVALUE32_64 it seems like we should have the IntValueDescriptor defined in JSValue, where it is for JSVALUE32_64 (better still, unify the two!)

r- for the reinterpreting.

[Build Bot]

Attachment 85520 [details] did not build on win:
Build output: http://queues.webkit.org/results/8132411

[Oliver Hunt]

Created attachment 85543 [details]
Patch

[Early Warning System Bot]

Attachment 85543 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8135475

[Build Bot]

Attachment 85543 [details] did not build on win:
Build output: http://queues.webkit.org/results/8133485

[Oliver Hunt]

Created attachment 85551 [details]
Patch

[Gavin Barraclough]

Comment on attachment 85551 [details]
Patch

r is me

[Build Bot]

Attachment 85551 [details] did not build on win:
Build output: http://queues.webkit.org/results/8149539

[WebKit Commit Bot]

Comment on attachment 85551 [details]
Patch

Clearing flags on attachment: 85551

Committed r80919: <http://trac.webkit.org/changeset/80919>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/80919 might have broken Windows Release (Build) and Windows Debug (Build)

[Ryosuke Niwa]

It seems like this change caused a Windows build failure:
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/13160

[Oliver Hunt]

The commit queue is broken and needs to be disabled.  I'll re-land on monday with the windows fix.

[Adam Barth]

> The commit queue is broken and needs to be disabled.

https://bugs.webkit.org/show_bug.cgi?id=56251#c5

[Oliver Hunt]

Committed r81040: <http://trac.webkit.org/changeset/81040>

[WebKit Review Bot]

http://trac.webkit.org/changeset/81040 might have broken Windows Release (Build) and Windows Debug (Build)