Bug 56205 – m_restrictions needs to allow multiple values (a bitfield)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

m_restrictions needs to allow multiple values (a bitfield)

[Dean Jackson]

Created attachment 85492 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 85492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85492&action=review

> Source/WebCore/ChangeLog:9
> +        https://bugs.webkit.org/show_bug.cgi?id=56205
> +        m_restrictions needs to allow multiple values (a bitfield)
> +
> +        Make the m_restrictions ivar of unsigned type, so that it
> +        can hold multiple values of BehaviorRestrictions.

Somewhere in this text you should mention media elements.

> Source/WebCore/html/HTMLMediaElement.h:363
> -    BehaviorRestrictions m_restrictions;
> +    unsigned m_restrictions;

I think you should add a typedef for BehaviorRestrictions, and rename the enum to BehaviorRestrictionFlags

[Dean Jackson]

Created attachment 85502 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 85502 [details]
Patch

Doesn't that feel better?

[Dean Jackson]

(In reply to comment #4)
> (From update of attachment 85502 [details])
> Doesn't that feel better?

I have a warm feeling in my stomach. I will sleep soundly tonight.

[Dean Jackson]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/html/HTMLMediaElement.h
Committed r80873