Bug 56192 - Web Inspector: "Exclude" button in Profiles view should really be called "Charge Symbol to Caller" (or similar) (affects Leaks Viewer)
Summary: Web Inspector: "Exclude" button in Profiles view should really be called "Cha...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 07:50 PST by Adam Roben (:aroben)
Modified: 2014-12-12 14:07 PST (History)
9 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-11 07:50:33 PST 
The Inspector's Profile view currently has an "Exclude" button. But what it does is really the same as this feature from Shark:

> Charge Symbol X to Callers— Removes any callstack frames containing the symbol X, and frames of functions called by X, effectively reassigning time spent in those functions to the callers.

"Exclude" is a confusing name for this behavior, and will become even more confusing if "Remove Callstacks with Symbol" is added (see bug 56191), since that is another form of "exclusion".
Comment 1 Brian Burg 2014-12-12 14:07:20 PST 
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.