Bug 56173 - Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
Summary: Web Inspector: split InjectedScriptHost into InjectedScriptManager and Inject...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 00:45 PST by Yury Semikhatsky
Modified: 2011-03-11 05:27 PST (History)
15 users (show)

See Also:

Attachments
Patch (93.82 KB, patch)
2011-03-11 00:59 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Patch for landing (98.97 KB, patch)
2011-03-11 05:14 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-03-11 00:45:45 PST 
Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost. InjectedScriptHost should only be used by the injected script  to access native parts of web inspector. All script managing stuff should go into InjectedScriptManager. Also the plan is to have InspectorController own InjectedScriptManager along with agents.
Comment 1 Yury Semikhatsky 2011-03-11 00:59:01 PST 
Created attachment 85443 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-11 01:10:31 PST 
Attachment 85443 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8132182
Comment 3 Pavel Feldman 2011-03-11 01:18:57 PST 
Comment on attachment 85443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85443&action=review

> Source/WebCore/bindings/js/JSInjectedScriptManager.cpp:2
> + * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.

I think this is all Google-originating code.
Comment 4 Build Bot 2011-03-11 01:24:41 PST 
Attachment 85443 [details] did not build on win:
Build output: http://queues.webkit.org/results/8133212
Comment 5 Yury Semikhatsky 2011-03-11 02:38:37 PST 
Committed r80837: <http://trac.webkit.org/changeset/80837>
Comment 6 WebKit Review Bot 2011-03-11 02:51:11 PST 
http://trac.webkit.org/changeset/80837 might have broken Qt Linux Release minimal, Qt Windows 32-bit Release, and Chromium Linux Release
Comment 7 Yury Semikhatsky 2011-03-11 05:07:19 PST 
Reopening since the change was rolled out in r80839.
Comment 8 Yury Semikhatsky 2011-03-11 05:14:57 PST 
Created attachment 85461 [details]
Patch for landing
Comment 9 Yury Semikhatsky 2011-03-11 05:27:47 PST 
Committed r80844: <http://trac.webkit.org/changeset/80844>