Bug 56171 - Fix textarea maxlength bug that return key is not considered.
Summary: Fix textarea maxlength bug that return key is not considered.
Status: RESOLVED DUPLICATE of bug 54443
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 21:31 PST by Naoki Takano
Modified: 2011-03-12 00:50 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2011-03-11 23:38 PST, Naoki Takano
ap: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naoki Takano 2011-03-10 21:31:57 PST
Fix textarea maxlength bug that return key is not considered.
Comment 1 Alexey Proskuryakov 2011-03-11 12:00:00 PST

*** This bug has been marked as a duplicate of bug 54443 ***
Comment 2 Naoki Takano 2011-03-11 23:38:16 PST
Created attachment 85574 [details]
Patch
Comment 3 Naoki Takano 2011-03-11 23:39:27 PST
Could you review?
Comment 4 Alexey Proskuryakov 2011-03-11 23:52:00 PST
Comment on attachment 85574 [details]
Patch

It should be possible to make an automated test for this. Manual tests are nearly useless.

Please attach patches to bug 54443, not here.
Comment 5 Naoki Takano 2011-03-12 00:03:47 PST
I try to make automate test.

But I'm not sure I can simulate key pressing in layout test.
Comment 6 Alexey Proskuryakov 2011-03-12 00:50:36 PST
You can look what existing tests for maxlength do for an example. See e.g. fast/forms/script-tests/textarea-maxlength.js, or other tests with "maxlength" in file name.