WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56158
support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158
Summary
support encoding /decoding WebData in usermessages
Alice Liu
Reported
2011-03-10 17:51:48 PST
UserMessage[De|En]coder::base[De|En]code are missing cases for APIObject::TypeData. This results in WKData not being able to be sent across ipc messages.
Attachments
patch
(2.47 KB, patch)
2011-03-10 19:37 PST
,
Alice Liu
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alice Liu
Comment 1
2011-03-10 19:37:14 PST
Created
attachment 85425
[details]
patch
Sam Weinig
Comment 2
2011-03-10 21:34:53 PST
Comment on
attachment 85425
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=85425&action=review
> Source/WebKit2/Shared/UserMessageCoders.h:305 > + coder.m_root = WebData::create(buffer); > + break; > + }
I think this should return true, hm, we are inconsistent here. I should fix that, the break is fine I guess.
Alice Liu
Comment 3
2011-03-11 19:35:52 PST
http://trac.webkit.org/changeset/80921
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug