The 'LayerTreeAsTextDebug' flag to GraphicsLayer::layerTreeAsText() as well as all the interesting 'RenderAsTextBehavior' flags for dumping render trees are currently not reachable at runtime from chromium's DumpRenderTree. I would like to add some plumbing to be able to optionally dump extra information.
Created attachment 85384 [details] Patch
Sample output for '--debug-render-tree' with Debug build: layer 0x7f815400aaa8 at (8,202) size 104x104 (composited, bounds at (0,0) size 104x104) RenderPartObject 0x7f815408e9c8 {IFRAME} at (0,96) size 104x104 [border: (2px inset #000000)] Sample output for '--debug-layer-tree' with Debug build: (children 1 (GraphicsLayer 0x46b9800 "GraphicsLayerChromium(0x46b99f0) GraphicsLayer(0x46b9800) RenderBlock DIV" (position 18.00 10.00) (bounds 110.00 110.00) (drawsContent 1) (client 0x46b97a0) Note that names are not available in Release DRT builds.
Comment on attachment 85384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85384&action=review > Source/WebCore/ChangeLog:6 > + [Chromium] Make 'RenderAsTextBehavior' and 'LayerTreeAsTextBehavior' tweakable from DumpRenderTree's commandline > + https://bugs.webkit.org/show_bug.cgi?id=56139 This isn't an XML or HTML file. Entities won't work. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Remove.
Created attachment 85385 [details] Patch
Comment on attachment 85385 [details] Patch Rejecting attachment 85385 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'bu..." exit_code: 2 Last 500 characters of output: dule -compatibility_version 1 -current_version 534.24 -o /Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore Undefined symbols: "__ZNK7WebCore5Frame15layerTreeAsTextEv", referenced from: -exported_symbol[s_list] command line option ld: symbol(s) not found collect2: ld returned 1 exit status ** BUILD FAILED ** The following build commands failed: WebCore: Ld /Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal x86_64 (1 failure) Full output: http://queues.webkit.org/results/8149159
Created attachment 85493 [details] Patch
Comment on attachment 85493 [details] Patch Updated the exported function signatures.
Comment on attachment 85493 [details] Patch Clearing flags on attachment: 85493 Committed r81094: <http://trac.webkit.org/changeset/81094>
All reviewed patches have been landed. Closing bug.
Sorry I had to roll this out (http://trac.webkit.org/changeset/81099). This caused breakage in Chromium land which you can see here: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/590/steps/compile/logs/stdio Here's a snippet from that build log: /b/build/slave/Webkit_Mac10_6/build/src/webkit/glue/media/buffered_data_source_unittest.cc: In member function 'void webkit_glue::BufferedDataSourceTest::InitializeDataSource(const char*, int, bool, int64, webkit_glue::NetworkState)': /b/build/slave/Webkit_Mac10_6/build/src/webkit/glue/media/buffered_data_source_unittest.cc:122:error: cannot allocate an object of abstract type 'testing::NiceMock<webkit_glue::MockWebFrame>' ../testing/gmock/include/gmock/gmock-generated-nice-strict.h:68: note: because the following virtual functions are pure within 'testing::NiceMock<webkit_glue::MockWebFrame>': ../third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h:552: note: virtual WebKit::WebString WebKit::WebFrame::renderTreeAsText(bool) const ../third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h:585: note: virtual WebKit::WebString WebKit::WebFrame::layerTreeAsText(bool) const
Provisional fix for chromium landed (http://codereview.chromium.org/6677069/). This can be applied now.
Comment on attachment 85493 [details] Patch Clearing flags on attachment: 85493 Committed r81603: <http://trac.webkit.org/changeset/81603>