Bug 56135 - VisiblePosition's next and previous should take an enum instead of a boolean
Summary: VisiblePosition's next and previous should take an enum instead of a boolean
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 53409
  Show dependency tree / graph
 
Reported: 2011-03-10 12:50 PST by Ryosuke Niwa
Modified: 2011-03-10 14:46 PST (History)
4 users (show)

See Also:

Attachments
cleanup (25.03 KB, patch)
2011-03-10 13:08 PST, Ryosuke Niwa 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-03-10 12:50:49 PST 
There many places where we call next(true) and previous(true) and it's totally unclear what it means.
Comment 1 Ryosuke Niwa 2011-03-10 13:08:47 PST 
Created attachment 85381 [details]
cleanup
Comment 2 Ryosuke Niwa 2011-03-10 13:16:02 PST 
Committed r80752: <http://trac.webkit.org/changeset/80752>
Comment 3 Ryosuke Niwa 2011-03-10 14:46:58 PST 
I accidentally reversed the boolean logic in the original patch.  Fixed it in http://trac.webkit.org/changeset/80766.