Bug 56134 - PlatformContextSkia should flush GrContext in destructor
Summary: PlatformContextSkia should flush GrContext in destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Salomon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 12:49 PST by Brian Salomon
Modified: 2011-03-11 00:07 PST (History)
5 users (show)

See Also:

Attachments
fix (2.64 KB, patch)
2011-03-10 12:51 PST, Brian Salomon 		no flags Details | Formatted Diff | Diff
patch (2.32 KB, patch)
2011-03-10 12:56 PST, Brian Salomon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Salomon 2011-03-10 12:49:49 PST 
When a PlatformContextSkia is backed by a GrContext it should flush the GrContext in its destructor. Otherwise, the GrRenderTarget that the skia canvas is drawing into refers to a DrawingBuffer's FBO id that may be destroyed before the next time the GrContext is flushed.
Comment 1 Brian Salomon 2011-03-10 12:51:33 PST 
Created attachment 85377 [details]
fix

This patch also changes the parameter passed to GrContext::flush from a boolean to a int. A recent change to skia made this parameter a bitfield of flags rather than a boolean.
Comment 2 Brian Salomon 2011-03-10 12:56:35 PST 
Created attachment 85378 [details]
patch
Comment 3 Kenneth Russell 2011-03-10 13:48:33 PST 
Comment on attachment 85378 [details]
patch

Looks fine.
Comment 4 WebKit Commit Bot 2011-03-11 00:07:04 PST 
Comment on attachment 85378 [details]
patch

Clearing flags on attachment: 85378

Committed r80826: <http://trac.webkit.org/changeset/80826>
Comment 5 WebKit Commit Bot 2011-03-11 00:07:09 PST 
All reviewed patches have been landed.  Closing bug.