Bug 56133 - [Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
Summary: [Qt] Warning that round/roundf functions are already defined when compiled wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P5 Minor
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-03-10 12:25 PST by Viatcheslav Ostapenko
Modified: 2011-03-14 16:47 PDT (History)
7 users (show)

See Also:

Attachments
#ifdef out math round replacement functions on RVCT from 3.0.0 (1.37 KB, patch)
2011-03-10 12:35 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2011-03-10 12:25:44 PST 
compile    : JavaScriptCore\wtf\DateMath.cpp  	[armv5_udeb.slimdebug]
   "W:/webkit/Source/JavaScriptCore/wtf/MathExtras.h", line 112: Warning:  #1559-D: dllexport/dllimport conflict with "round" (declared at line 344 of "W:/epoc32/include/stdapis/math.h"); dllexport assumed
     static double round(double num)
                   ^
   "W:/webkit/Source/JavaScriptCore/wtf/MathExtras.h", line 119: Warning:  #1559-D: dllexport/dllimport conflict with "roundf" (declared at line 405 of "W:/epoc32/include/stdapis/math.h"); dllexport assumed
     static float roundf(float num)
Comment 1 Viatcheslav Ostapenko 2011-03-10 12:35:33 PST 
Created attachment 85371 [details]
#ifdef out math round replacement functions on RVCT from 3.0.0
Comment 2 Laszlo Gombos 2011-03-10 15:25:42 PST 
CCing Nick, Daniel and Kwang for their feedback. The change in the code looks good to me.
Comment 3 Laszlo Gombos 2011-03-14 09:59:16 PDT 
Comment on attachment 85371 [details]
#ifdef out math round replacement functions on RVCT from 3.0.0

LGTM, r=me.
Comment 4 WebKit Commit Bot 2011-03-14 16:47:27 PDT 
Comment on attachment 85371 [details]
#ifdef out math round replacement functions on RVCT from 3.0.0

Clearing flags on attachment: 85371

Committed r81081: <http://trac.webkit.org/changeset/81081>
Comment 5 WebKit Commit Bot 2011-03-14 16:47:31 PDT 
All reviewed patches have been landed.  Closing bug.