Bug 56127 - Fix allocation of native function with a cached thunk
Summary: Fix allocation of native function with a cached thunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 11:38 PST by Oliver Hunt
Modified: 2011-03-11 04:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.45 KB, patch)
2011-03-10 11:40 PST, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-03-10 11:38:53 PST 
Fix allocation of native function with a cached thunk
Comment 1 Oliver Hunt 2011-03-10 11:40:14 PST 
Created attachment 85355 [details]
Patch
Comment 2 Gavin Barraclough 2011-03-10 12:31:56 PST 
Fixed in r80743
Comment 3 Oliver Hunt 2011-03-10 12:36:27 PST 
Errr wrong bug mate :)
Comment 4 Oliver Hunt 2011-03-10 13:17:08 PST 
Committed r80751: <http://trac.webkit.org/changeset/80751>
Comment 5 Gavin Barraclough 2011-03-10 14:02:48 PST 
Oooops!
Comment 6 Sergio Villar Senin 2011-03-11 03:02:35 PST 
I think this commit maybe the source of some JSC crashes in GTK 32bit Release bot we have been observing recently. In particular these two tests are failing consistently since then:

fast/profiler/dead-time.html
fast/profiler/stop-profiling-after-setTimeout.html
Comment 7 Sergio Villar Senin 2011-03-11 04:08:55 PST 
(In reply to comment #6)
> I think this commit maybe the source of some JSC crashes in GTK 32bit Release bot we have been observing recently. In particular these two tests are failing consistently since then:
> 
> fast/profiler/dead-time.html
> fast/profiler/stop-profiling-after-setTimeout.html

Looks like I was wrong, after reverting 80742 and 80743 no crash at all. Sorry for the noise.