Bug 56123 – Web Inspector: move breakpoints restoring to debugger presentation model

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: move breakpoints restoring to debugger presentation model.

DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since setBreakpoint/removeBreakpoint are now called from DPM only.

[Pavel Podivilov]

Created attachment 85352 [details]
Patch.

[Pavel Feldman]

Comment on attachment 85352 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=85352&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:51
> +            this._breakpointsRestored = true;

debugger is enabled with no state, we should restore breakpoints in all cases.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:60
> +            if (id in this._breakpoints)

this._uiBreakpoints

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:196
> +            if (typeof breakpoint.url !== "string" || typeof breakpoint.lineNumber !== "number" || typeof breakpoint.columnNumber !== "number" ||

How can this happen?

[Pavel Podivilov]

Committed r81025: <http://trac.webkit.org/changeset/81025>

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 85352 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85352&action=review
> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:51
> > +            this._breakpointsRestored = true;
> 
> debugger is enabled with no state, we should restore breakpoints in all cases.

Now breakpoints is cleared from cookie when debugger is disabled.

> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:60
> > +            if (id in this._breakpoints)
> 
> this._uiBreakpoints
> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:196
> > +            if (typeof breakpoint.url !== "string" || typeof breakpoint.lineNumber !== "number" || typeof breakpoint.columnNumber !== "number" ||
> 
> How can this happen?
Done.