Bug 56122 - Remove unnecessary function WebPlugin::getBackingTextureId
Summary: Remove unnecessary function WebPlugin::getBackingTextureId
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alok Priyadarshi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 10:40 PST by Alok Priyadarshi
Modified: 2011-03-15 10:14 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (2.30 KB, patch)
2011-03-10 10:47 PST, Alok Priyadarshi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alok Priyadarshi 2011-03-10 10:40:03 PST 
WebPlugin::getBackingTextureId is not required anymore. We use WebPluginContainer::setBackingTextureId now.
Comment 1 Alok Priyadarshi 2011-03-10 10:47:40 PST 
Created attachment 85349 [details]
proposed patch
Comment 2 Antoine Labour 2011-03-10 10:55:20 PST 
LGTM FWIW
Comment 3 Alok Priyadarshi 2011-03-14 13:50:41 PDT 
ping!
Comment 4 Alok Priyadarshi 2011-03-15 09:00:43 PDT 
Hi James: Please review.
Comment 5 James Robinson 2011-03-15 09:48:46 PDT 
Comment on attachment 85349 [details]
proposed patch

FYI getters in WebKit should not have a "get"prefix (it should be "textureId()", not getTextureId().
Comment 6 WebKit Commit Bot 2011-03-15 10:14:38 PDT 
Comment on attachment 85349 [details]
proposed patch

Clearing flags on attachment: 85349

Committed r81143: <http://trac.webkit.org/changeset/81143>
Comment 7 WebKit Commit Bot 2011-03-15 10:14:42 PDT 
All reviewed patches have been landed.  Closing bug.