Bug 56111 – Web Inspector: Optimize backend-frontend data transfer volume for CSS styles

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Currently every CSS property is described by a number of key:value pairs in the Web Inspector protocol. This results in computed style transfers of about 30kB for ~220 properties and should certainly be reworked (this is often slow even without remote debugging).

[Alexander Pavlov (apavlov)]

Created attachment 85350 [details]
[PATCH] Suggested solution

[Patrick Mueller]

Makes sense.  I'm curious how  much this saves.  

I've been noticing for weinre that computed styles are coming over far too often, as near as I can tell.  For instance, I see them come over even if the computed style disclosure is set to "hide".  Might well be something I'm doing wrong, or something that's changed since I last caught up to WI, of maybe they need to come over anyway for some other calculation.

[Pavel Feldman]

(In reply to comment #2)
> Makes sense.  I'm curious how  much this saves.  
> 
> I've been noticing for weinre that computed styles are coming over far too often, as near as I can tell.  For instance, I see them come over even if the computed style disclosure is set to "hide".  Might well be something I'm doing wrong, or something that's changed since I last caught up to WI, of maybe they need to come over anyway for some other calculation.

Good point - I think we are sending computed style information regardless of the sidebar section state.

[Ilya Tikhonovsky]

was landed as r80845

[Ilya Tikhonovsky]

was landed as r80845(In reply to comment #4)
> was landed as r80845

wrong bug

[Pavel Feldman]

Comment on attachment 85350 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=85350&action=review

> LayoutTests/inspector/styles/styles-new-API.html:244
> +                InspectorTest.addResult("['" + property.name + "':'" + property.value + "'" + (property.priority === "important" ? " is-important" : "") + ((typeof property.parsedOk === "undefined") ? "" : " non-parsed") +"] @[" + property.startOffset + "-" + property.endOffset + "] " + (property.status || "style"));

("parsedOk" in property)

> Source/WebCore/inspector/InspectorStyleSheet.cpp:453
> +        String status = it->disabled ? "disabled" : "active";

I'd suggest that:
- active properties have no additional flags,
- disabled properties have "disabled" set to true,
- style (longhand) properties are placed under source code (shorthand) properties in case of regular styles + computed styles are returned as arrays of longhands.

[Alexander Pavlov (apavlov)]

Committed r81019: <http://trac.webkit.org/changeset/81019>