Bug 56098 – [Qt] MSVC Build Error - need to link advapi32.lib for jsc.exe

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jarred Nicholls]

OSRandomnSource.cpp utilizes the Crypto API found in advapi32.  Linker error when linking jsc.exe (against jscore.lib), needs to include advapi32.lib in jsc.pro.

[Jarred Nicholls]

Created attachment 85321 [details]
Proposed patch

[Alexis Menard (darktears)]

I wonder why it does not happen on my windows XP.

[Jarred Nicholls]

(In reply to comment #2)
> I wonder why it does not happen on my windows XP.

You are building the Qt port?

"perl build-webkit --qt --release"

VC++ 9 reports unresolved symbols when linking jsc.exe, requiring an explicit addition of advapi32.lib on the link command line.  `#pragma comment(lib, "advapi32")` works as well.

[Alexis Menard (darktears)]

(In reply to comment #3)
> (In reply to comment #2)
> > I wonder why it does not happen on my windows XP.
> 
> You are building the Qt port?

:) Yep.

> 
> "perl build-webkit --qt --release"
> 
> VC++ 9 reports unresolved symbols when linking jsc.exe, requiring an explicit addition of advapi32.lib on the link command line.  `#pragma comment(lib, "advapi32")` works as well.

VC++ 9 is the one included with Visual Studio 2010 express right? Because I'm building with the one in Visual Studio 2008. Perhaps that explain.

[Jarred Nicholls]

(In reply to comment #4)
> > VC++ 9 reports unresolved symbols when linking jsc.exe, requiring an explicit addition of advapi32.lib on the link command line.  `#pragma comment(lib, "advapi32")` works as well.
> 
> VC++ 9 is the one included with Visual Studio 2010 express right? Because I'm building with the one in Visual Studio 2008. Perhaps that explain.

Interestingly enough, no :)  VC9 is 2008, VC10 is 2010.  So we're using the same version of Express.

[Ariya Hidayat]

Comment on attachment 85321 [details]
Proposed patch

LGTM. re=me

[WebKit Commit Bot]

Comment on attachment 85321 [details]
Proposed patch

Rejecting attachment 85321 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1

Last 500 characters of output:
rm/gtk/Skipped
	M	LayoutTests/platform/win/Skipped
	M	LayoutTests/platform/mac/Skipped
	A	LayoutTests/fast/forms/interactive-validation-select-crash-expected.txt
	A	LayoutTests/fast/forms/interactive-validation-select-crash.html
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/rendering/RenderBlock.cpp
r81088 = 32441d26af2feea641046d75af74f9441dbcbe92 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8175430

[Jarred Nicholls]

I was cavalier with the patch and didn't leave an Unreviewed line.  Can this get committed manually?  Otherwise I'll reupload tomorrow.

[Benjamin Poulain]

Committed r81963: <http://trac.webkit.org/changeset/81963>