Bug 56089 - [GTK] run-gtk-tests doesn't fail if a test crashes
Summary: [GTK] run-gtk-tests doesn't fail if a test crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 04:12 PST by Philippe Normand
Modified: 2011-03-10 07:12 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (1.60 KB, patch)
2011-03-10 04:18 PST, Philippe Normand
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-03-10 04:12:42 PST
One test crashing for a week and a green "unittests" box in the waterfall... See also https://bugs.webkit.org/show_bug.cgi?id=56083
Comment 1 Philippe Normand 2011-03-10 04:18:58 PST
Created attachment 85307 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2011-03-10 05:50:44 PST
Comment on attachment 85307 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85307&action=review

> Tools/Scripts/run-gtk-tests:41
> +    if (!$exitStatus && $?) {
> +        $exitStatus = $?;

No need to check whether exitstatus is already set, I think, just check that $? is non-zero and assign unconditionally.
Comment 3 Philippe Normand 2011-03-10 06:14:21 PST
Committed r80712: <http://trac.webkit.org/changeset/80712>
Comment 4 WebKit Review Bot 2011-03-10 07:07:51 PST
http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug
Comment 5 Philippe Normand 2011-03-10 07:12:57 PST
(In reply to comment #4)
> http://trac.webkit.org/changeset/80712 might have broken GTK Linux 64-bit Debug

It was broken already before, this patch just unveiled previously undetected redness.