Bug 56071 - [NRWT] We should write an image to the LayoutTest result directory even if driver_output.image is empty.
Summary: [NRWT] We should write an image to the LayoutTest result directory even if dr...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-09 21:24 PST by Hayato Ito
Modified: 2011-03-09 22:29 PST (History)
2 users (show)

See Also:


Attachments
write-empty-image (1.64 KB, patch)
2011-03-09 21:35 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2011-03-09 21:24:27 PST
I've found that the previous test's result image is wrongly shown in the results.html in the following scenario.

Suppose we have a test, foo.html. 

In the first run, the test run successfully and the driver_output.image was written to the LayoutTest result directory as a 'foo-actual.png'.
In the second run, suppose timeout happend. In this case, the driver_output.image was '' (empty string). So test_result_writer will skip writing the image.
As a result, the previous 'foo-actual.png' is used in results.html. That is confusing. The previoius result image was overwritten with empty_image.
Comment 1 Hayato Ito 2011-03-09 21:35:38 PST
Created attachment 85283 [details]
write-empty-image
Comment 2 Hayato Ito 2011-03-09 21:41:28 PST
I think when CRASH or TIMEOUT occurs, we don't have to use a result image.
But for some (historical?) reasons, new-run-webkit-tests tries to compare_image even in TIMEOUT occurs.
So we need this change to avoid confusion.
Comment 3 Hayato Ito 2011-03-09 22:06:46 PST
I've found that we don't need this patch for now.
When timeout occurs, the driver returns None as image_hash.
So _compare_image will exit early in this case. So results.html won't contain the link to the previous result image.
Comment 4 Dirk Pranke 2011-03-09 22:23:42 PST
presumably this should be WONTFIX or WORKSFORME instead of FIXED?
Comment 5 Hayato Ito 2011-03-09 22:29:07 PST
Yeah, I changed it to WONTFIX. Thank you.