RESOLVED FIXED 56053
Deleting content directly following a button inserts an unnecessary placeholder 
https://bugs.webkit.org/show_bug.cgi?id=56053
Summary Deleting content directly following a button inserts an unnecessary placeholder
Levi Weintraub
Reported 2011-03-09 14:43:27 PST
See attachment. Deleting any content directly following a button adds a br "placeholder" to the DOM, which is unexpected. Simply place the caret after the space following the button and hit backspace to repro.
Attachments
Patch (4.24 KB, patch)
2011-03-09 16:08 PST, Levi Weintraub 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-03-09 16:08:29 PST
Created attachment 85253 [details] Patch
Ryosuke Niwa
Comment 2 2011-03-14 11:31:12 PDT
Comment on attachment 85253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review looks sane to me. > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9 > +target = document.getElementById("container"); Nit: Missing "var". > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11 > +window.getSelection().modify("move", "Right", "character"); Nit: Capitalize / de-capitalize all words here (make them consistent).
Levi Weintraub
Comment 3 2011-03-14 12:35:55 PDT
(In reply to comment #2) > (From update of attachment 85253 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review > > looks sane to me. > > > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9 > > +target = document.getElementById("container"); > > Nit: Missing "var". > > > LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11 > > +window.getSelection().modify("move", "Right", "character"); > > Nit: Capitalize / de-capitalize all words here (make them consistent). Thanks for the review! I'll fix those and land :)
Levi Weintraub
Comment 4 2011-03-14 14:19:46 PDT
Committed r81056: <http://trac.webkit.org/changeset/81056>
Note You need to log in before you can comment on or make changes to this bug.