Bug 56048 - Clean up some gross code in chromium/TestShellWin.cpp
Summary: Clean up some gross code in chromium/TestShellWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-09 13:29 PST by Peter Kasting
Modified: 2011-03-10 22:45 PST (History)
3 users (show)

See Also:

Attachments
patch v1 (4.28 KB, patch)
2011-03-09 13:31 PST, Peter Kasting 		no flags Details | Formatted Diff | Diff
patch v2 (4.24 KB, patch)
2011-03-09 14:19 PST, Peter Kasting 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2011-03-09 13:29:33 PST 
The Windows version check stuff in TestShellWin.cpp is horrid.  Patch momentarily.
Comment 1 Peter Kasting 2011-03-09 13:31:49 PST 
Created attachment 85223 [details]
patch v1
Comment 2 Peter Kasting 2011-03-09 14:19:11 PST 
Created attachment 85232 [details]
patch v2

Switch to using OSVERSIONINFO because it's slightly cleaner.
Comment 3 Dimitri Glazkov (Google) 2011-03-09 14:51:46 PST 
Comment on attachment 85232 [details]
patch v2

k
Comment 4 WebKit Commit Bot 2011-03-10 19:36:57 PST 
Comment on attachment 85232 [details]
patch v2

Rejecting attachment 85232 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2

Last 500 characters of output:
	Source/WebCore/page/Page.cpp
	M	Source/WebCore/page/FrameView.h
	M	Source/WebCore/platform/ScrollView.cpp
	M	Source/WebCore/platform/ScrollView.h
	M	Source/WebCore/rendering/RenderLayer.cpp
	M	Source/WebCore/rendering/RenderListBox.cpp
	M	Source/WebCore/rendering/RenderLayer.h
	M	Source/WebCore/rendering/RenderDataGrid.cpp
r80804 = 0bcced00a0585c5936e8c2aee745dcf8dd87c118 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8135143
Comment 5 WebKit Commit Bot 2011-03-10 22:45:38 PST 
Comment on attachment 85232 [details]
patch v2

Clearing flags on attachment: 85232

Committed r80817: <http://trac.webkit.org/changeset/80817>
Comment 6 WebKit Commit Bot 2011-03-10 22:45:42 PST 
All reviewed patches have been landed.  Closing bug.