Bug 56032 - Leaks viewer should be linked from leaks bot results page
Summary: Leaks viewer should be linked from leaks bot results page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on: 56028
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-09 11:10 PST by David Kilzer (:ddkilzer)
Modified: 2011-04-07 09:10 PDT (History)
1 user (show)

See Also:


Attachments
Add a "view leaks" link to builds on SnowLeopard Intel Leaks (4.67 KB, patch)
2011-04-06 14:36 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff
Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete() (3.54 KB, patch)
2011-04-07 06:28 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished() (2.99 KB, patch)
2011-04-07 07:13 PDT, Adam Roben (:aroben)
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-03-09 11:10:38 PST
The leaks viewer should be linked directly from the leaks bot results page.
Comment 1 Adam Roben (:aroben) 2011-04-06 14:36:50 PDT
Created attachment 88515 [details]
Add a "view leaks" link to builds on SnowLeopard Intel Leaks
Comment 2 David Kilzer (:ddkilzer) 2011-04-06 14:41:00 PDT
Comment on attachment 88515 [details]
Add a "view leaks" link to builds on SnowLeopard Intel Leaks

r=me!
Comment 3 Adam Roben (:aroben) 2011-04-06 14:58:13 PDT
Committed r83101: <http://trac.webkit.org/changeset/83101>
Comment 4 Adam Roben (:aroben) 2011-04-06 15:48:52 PDT
This seems not to have worked: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/16078
Comment 5 Adam Roben (:aroben) 2011-04-06 16:06:48 PDT
Maybe we need to call self.addURL before calling MasterShellCommand.finished. Maybe we should move the addURL calls to createSummary, like in the examples on <http://buildbot.net/buildbot/docs/current/BuildStep-URLs.html#BuildStep-URLs>?
Comment 6 Adam Roben (:aroben) 2011-04-07 06:28:27 PDT
Created attachment 88617 [details]
Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
Comment 7 Adam Roben (:aroben) 2011-04-07 06:47:31 PDT
Committed r83168: <http://trac.webkit.org/changeset/83168>
Comment 8 Adam Roben (:aroben) 2011-04-07 07:13:32 PDT
Another failure:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/10463

Now the "view results" URL is gone, too! :-(
Comment 9 Adam Roben (:aroben) 2011-04-07 07:13:52 PDT
Created attachment 88628 [details]
Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
Comment 10 Adam Roben (:aroben) 2011-04-07 07:17:24 PDT
Committed r83170: <http://trac.webkit.org/changeset/83170>
Comment 11 Adam Roben (:aroben) 2011-04-07 09:10:52 PDT
Seems to be working now: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/16096