Bug 56015 - Web Inspector: Highlighter refactoring
Summary: Web Inspector: Highlighter refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-09 07:21 PST by Andrey Adaikin
Modified: 2011-03-10 04:11 PST (History)
11 users (show)

See Also:


Attachments
Patch (23.95 KB, patch)
2011-03-09 07:27 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Patch (24.31 KB, patch)
2011-03-09 09:20 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2011-03-09 07:21:55 PST
Highlighter refactoring to get rid of the current highlighter state (this._lastHighlightedLine & this._lastHighlightedColumn).

Also I found a bug in the old highlighter in the updateHighlight() method, added a test that fails the old implementation.
Comment 1 Andrey Adaikin 2011-03-09 07:27:11 PST
Created attachment 85173 [details]
Patch
Comment 2 Andrey Adaikin 2011-03-09 09:20:46 PST
Created attachment 85183 [details]
Patch
Comment 3 Pavel Podivilov 2011-03-10 04:11:12 PST
Comment on attachment 85183 [details]
Patch

Clearing flags on attachment: 85183

Committed r80704: <http://trac.webkit.org/changeset/80704>
Comment 4 Pavel Podivilov 2011-03-10 04:11:25 PST
All reviewed patches have been landed.  Closing bug.